Error in Wave Doc : Incorrect URL construction

Solved
happytodev

Dec 14th, 2024 03:38 AM

Hello,

I found another bad link in doc.

In this page, Using filament with Volt, at the beginning, the link to the page 'Your functionality' has an incorrect url construction :

https://devdojo.com/wave/docs/guides/%7B%20url('/docs/your-functionality'%20)%7D

The good url is https://devdojo.com/wave/docs/your-functionality

I hope it helps.

Fred

Report
1
happytodev

Dec 14th, 2024 03:27 PM

This url helper is used almost everywhere in the doc. So many links are broken. If you want, I can help you by making PR but tell me what is the correct structure.

Another example : https://github.com/thedevdojo/wave-website/blob/main/content/docs/guides/%7B%20url('/docs')%20%7D

bobbyiliev

Dec 15th, 2024 07:43 AM

Hi there!

Thank you again for taking the time to report this!

I've just submitted a fix for this and it should be live on the site soon!

Very much appreciated!

- Bobby

Report
1
bobbyiliev

Dec 15th, 2024 07:44 AM

Best Answer

I think that the issue here is with the static site generator that we have:

https://static.devdojo.com/

As far as I can tell it is not parsing this correctly if there is a space after the closing bracket:

This works:

{ url('/docs/features/volt') }

This breaks:

{ url('/docs/features/volt' )}
Report
1
happytodev

Dec 15th, 2024 08:04 AM

Nice, I will look carefully and if I see another one I will submit a PR.

Report
1